Adding optional parameter to add a default a-tag class to the MvcLink… #21
Conversation
… if the linkField does not have one defiend. Fixing string comparisons so a-tag and alternateTags are created correctly.
There was a problem hiding this comment.
If the LinkField has a Class property already why do we need this extra property?
The property should be called linkClass not linkTagClass if it's actually needed to be consistent with the rest of the fields.
If we do need the property could we use the value in the "linkTagClass" and add it to the linkField before calling MvcLink?
|
@royhyde-dd please update the version in the csproj file to be 2.1.0.0 so that we can use this as a basis for a new nuget package |
@hollywoodinvegas, in some cases, we want to add a class without the user needing to add a class. It is to resolve https://hub.deloittedigital.com.au/jira/browse/DSP-136. In that case, the class |
There was a problem hiding this comment.
Happy for this to be merged, @royhyde-dd can you follow up on how we push this to nuget as version 2.1.0.0
This reverts commit 9009d4d.
|
I think the behaviour here is a little weird as it'll use either the link's class or the supplied class. If a class is provided via If both fields have a value should this create a |
|
If both are set should we use both or does one override? In which case we should call the field defaultClass or overrideClass usually the FEDs are pretty good with stacking so you. Can probably just add both classes |
…he XE, as there are issues with displaying components with these taks in 9.1 in the XE when the component only has a section tag surrounding it.
… if the linkField does not have one defined. Fixing string comparisons so a-tag and alternateTags are created correctly.